Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ana/delete txs message details for validators #3454

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

Bitcoinera
Copy link
Contributor

Closes #ISSUE

Description:

In this PR I delete everything referring to EditValidatorMessageDetails, CreateValidatorMessageDetails, SetWithdrawAddressMessageDetails and UnjailMessageDetails.

We still need to filter these transactions out in the API in case one day a validator decides to use Lunie (could be). Not in Cosmos, but in e-Money there are a lot of transactions of this kind:

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@jbibla jbibla merged commit 43c68f9 into develop Jan 24, 2020
@jbibla jbibla deleted the ana/remove-validators-tx-message-details branch January 24, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants